feat: Implement notifications section #1694

ShridharGoel · 2019-06-05T20:14:20Z

Fixes #1693

ci-reporter · 2019-06-05T20:15:42Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 28d9939. Here's the output:

`Run Tests`

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 2fc646e

`Test Coverage`

Failed build for f637d5d

`Run Tests`

Failed build for a294896

`Run Tests`

Failed build for 1200217

`Run Tests`

Failed build for f2b6a32

`Test Coverage`

Failed build for f2b6a32

`Test Coverage`

Failed build for 7b24c2c

`Run Tests`

Failed build for e8f5c6d

`Run Tests`

Failed build for 7b24c2c

`Run Tests`

Failed build for 7b24c2c

`Run Tests`

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

liveHarshit · 2019-06-07T08:26:59Z

app/src/main/java/com/eventyay/organizer/data/db/configuration/OrgaDatabase.java

@@ -310,4 +311,20 @@ public void onPreMigrate() {
        }
    }

+    @Migration(version = 20, database = OrgaDatabase.class)


version = VERSION

Wouldn't it be better to keep it like this only since when migrating to the next version we'll have to change this again? Because older versions are not removed.

version = VERSION is wrong. Migrations will never run correctly if written that way

iamareebjamal · 2019-06-09T06:57:22Z

Remove divider

ShridharGoel · 2019-06-09T06:59:29Z

Remove divider

Done.

* build(deps): bump appcompat from 1.1.0-alpha04 to 1.1.0-alpha05 (#1634) Bumps appcompat from 1.1.0-alpha04 to 1.1.0-alpha05. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-compiler from 2.1.0-alpha04 to 2.2.0-alpha01 (#1633) Bumps lifecycle-compiler from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump recyclerview from 1.1.0-alpha04 to 1.1.0-alpha05 (#1630) Bumps recyclerview from 1.1.0-alpha04 to 1.1.0-alpha05. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump annotation from 1.1.0-beta01 to 1.1.0-rc01 (#1628) Bumps annotation from 1.1.0-beta01 to 1.1.0-rc01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-common-java8 from 2.1.0-alpha04 to 2.2.0-alpha01 (#1631) Bumps lifecycle-common-java8 from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * fix: Remove sticky headers from Attendees fragment (#1636) * build(deps): bump lifecycle-extensions from 2.1.0-alpha04 to 2.2.0-alpha01 (#1629) Bumps lifecycle-extensions from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump core-testing from 2.1.0-alpha02 to 2.1.0-beta01 (#1635) Bumps core-testing from 2.1.0-alpha02 to 2.1.0-beta01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-runtime from 2.1.0-alpha04 to 2.2.0-alpha01 (#1632) Bumps lifecycle-runtime from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * fix: Prevent closing of Edit Event without confirmation dialog (#1639) * chore: Convert SalesSummaryPresenter to ViewModel (#1642) * feat: Pagination in Attendees list (#1637) * fix: Prevent crash at check-in on second page onwards (#1647) * chore: Add unit tests for SalesSummaryViewModel (#1644) * chore: Add unit tests for SalesSummaryViewModel * chore: Add unit tests for SalesSummaryViewModel * feat: Integrate Error Prone (#1582) * feat: Integrate error prone * Update Error Prone version * build(deps): bump threetenbp from 1.3.8 to 1.4.0 (#1640) Bumps [threetenbp](https://github.com/ThreeTen/threetenbp) from 1.3.8 to 1.4.0. - [Release notes](https://github.com/ThreeTen/threetenbp/releases) - [Changelog](https://github.com/ThreeTen/threetenbp/blob/master/RELEASE-NOTES.md) - [Commits](ThreeTen/threetenbp@v1.3.8...v1.4.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump gradle from 3.4.0 to 3.4.1 (#1645) Bumps gradle from 3.4.0 to 3.4.1. Signed-off-by: dependabot[bot] <support@dependabot.com> * chore: Update LeakCanary (#1649) * fix: Refresh Sponsors list automatically on deletion of items (#1651) * fix: Update Sponsors list automatically on creation of new item (#1652) * build(deps): bump logging-interceptor from 3.14.1 to 3.14.2 (#1655) Bumps logging-interceptor from 3.14.1 to 3.14.2. Signed-off-by: dependabot[bot] <support@dependabot.com> * chore: Migrate FeedbackListPresenter to ViewModel (#1657) * chore: Migrate FeedbackListPresenter to ViewModel * chore: Migrate FeedbackListPresenter to ViewModel * chore: Migrate FaqListPresenter to ViewModel (#1659) * fix: Dismiss clear button when amount becomes zero (#1421) * fix: Dismiss clear button when amount becomes zero * fix: Dismiss clear button when amount becomes zero * Fix style problem * Add space after if * Update README.md * Delete .gitkeep * fix: DatePicker and TimePicker doesn't display time chosen before when clicked (#1551) Changes: - Retain value of current time so in the AbstractDateTimePicker class Fixes #1548 * fix: Prevent crash on refreshing Event Dashboard (#1675) * fix: Update check-in system to work properly (#1673) * fix: Update check-in system to work properly * fix: Update check-in system to work properly * fix: Update check-in system to work properly * build(deps): bump mockito-inline from 2.27.0 to 2.28.1 (#1677) Bumps [mockito-inline](https://github.com/mockito/mockito) from 2.27.0 to 2.28.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v2.27.0...v2.28.1) * build(deps): bump mockito-inline from 2.28.1 to 2.28.2 (#1679) Bumps [mockito-inline](https://github.com/mockito/mockito) from 2.28.1 to 2.28.2. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v2.28.1...v2.28.2) Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump espresso-core from 3.2.0-beta01 to 3.2.0 (#1682) Bumps espresso-core from 3.2.0-beta01 to 3.2.0. Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump material from 1.1.0-alpha06 to 1.1.0-alpha07 (#1681) Bumps [material](https://github.com/material-components/material-components-android) from 1.1.0-alpha06 to 1.1.0-alpha07. - [Release notes](https://github.com/material-components/material-components-android/releases) - [Commits](https://github.com/material-components/material-components-android/commits) Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * feat: Implement system of role invites (#1680) * feat: Implement system of role invites * feat: Implement system of role invites * Update unit tests * feat: Implement system of role invites * feat: Implement system of role invites * fix: Prevent unresponsive FAQ fragment issue (#1687) * build(deps): bump gradle-errorprone-plugin from 0.8 to 0.8.1 (#1688) Bumps gradle-errorprone-plugin from 0.8 to 0.8.1. Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * fix: Show correct state of map display checkbox (#1692) * build(deps): bump recyclerview from 1.1.0-alpha05 to 1.1.0-alpha06 (#1697) Bumps recyclerview from 1.1.0-alpha05 to 1.1.0-alpha06. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump annotation from 1.1.0-rc01 to 1.1.0 (#1695) Bumps annotation from 1.1.0-rc01 to 1.1.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump appcompat from 1.1.0-alpha05 to 1.1.0-beta01 (#1696) Bumps appcompat from 1.1.0-alpha05 to 1.1.0-beta01. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * feat: Implement notifications section (#1694) * feat: Implement notifications section * Remove item divider * Remove unused imports * chore: Bump version code and name for release of v1.2.0 (#1703)

fossasia deleted a comment Jun 5, 2019

ShridharGoel changed the title ~~[WIP] feat: Implement notifications section~~ feat: Implement notifications section Jun 6, 2019

auto-label bot added the feature label Jun 6, 2019

ShridharGoel changed the title ~~feat: Implement notifications section~~ [WIP] feat: Implement notifications section Jun 6, 2019

auto-label bot removed the feature label Jun 6, 2019

fossasia deleted a comment Jun 6, 2019

ShridharGoel changed the title ~~[WIP] feat: Implement notifications section~~ feat: Implement notifications section Jun 6, 2019

auto-label bot added the feature label Jun 6, 2019

fossasia deleted a comment Jun 6, 2019

fossasia deleted a comment Jun 7, 2019

ShridharGoel added 2 commits June 7, 2019 13:15

feat: Implement notifications section

28d9939

Merge branch 'development' into notifications-list

2d0bbd2

fossasia deleted a comment Jun 7, 2019

liveHarshit reviewed Jun 7, 2019

View reviewed changes

liveHarshit approved these changes Jun 7, 2019

View reviewed changes

liveHarshit previously approved these changes Jun 7, 2019

View reviewed changes

Remove item divider

5fe9005

ShridharGoel dismissed liveHarshit’s stale review via 5fe9005 June 9, 2019 06:58

Remove unused imports

d3a0194

fossasia deleted a comment Jun 9, 2019

iamareebjamal approved these changes Jun 9, 2019

View reviewed changes

iamareebjamal merged commit 52a1895 into fossasia:development Jun 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement notifications section #1694

feat: Implement notifications section #1694

ShridharGoel commented Jun 5, 2019 •

edited

ci-reporter bot commented Jun 5, 2019 •

edited

`Test Coverage`

`Run Tests`

`Run Tests`

`Run Tests`

`Test Coverage`

`Test Coverage`

`Run Tests`

`Run Tests`

`Run Tests`

`Run Tests`

liveHarshit Jun 7, 2019

ShridharGoel Jun 7, 2019

iamareebjamal Jun 8, 2019

iamareebjamal commented Jun 9, 2019

ShridharGoel commented Jun 9, 2019

feat: Implement notifications section #1694

feat: Implement notifications section #1694

Conversation

ShridharGoel commented Jun 5, 2019 • edited

ci-reporter bot commented Jun 5, 2019 • edited

The build is failing

Run Tests

Test Coverage

Run Tests

Run Tests

Run Tests

Test Coverage

Test Coverage

Run Tests

Run Tests

Run Tests

Run Tests

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

liveHarshit Jun 7, 2019

Choose a reason for hiding this comment

ShridharGoel Jun 7, 2019

Choose a reason for hiding this comment

iamareebjamal Jun 8, 2019

Choose a reason for hiding this comment

iamareebjamal commented Jun 9, 2019

ShridharGoel commented Jun 9, 2019

ShridharGoel commented Jun 5, 2019 •

edited

ci-reporter bot commented Jun 5, 2019 •

edited

`Run Tests`

`Test Coverage`

`Run Tests`

`Run Tests`

`Run Tests`

`Test Coverage`

`Test Coverage`

`Run Tests`

`Run Tests`

`Run Tests`

`Run Tests`