Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Fix dependencies for Debian Buster #1392

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 1, 2019

Description

Fix the dependencies for Debian Buster (10).

How to test

  1. Check if all the listed dependencies can be installed without conflicts on all supported distros (at least on stretch and buster).
  2. Check if FOSSology can be compiled successfully.

@ag4ums
Copy link
Contributor

ag4ums commented Sep 5, 2019

composer is breaking while installing from source
image

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx
Copy link
Member Author

GMishx commented Sep 5, 2019

composer is breaking while installing from source

This appears to be an issue with composer itself not being compatible with PHP 7.3. Try upgrading composer using composer self-update or manually reinstalling it.

@ag4ums
Copy link
Contributor

ag4ums commented Sep 5, 2019

well then why not updating the composer in the utils/install_composer.sh

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx
Copy link
Member Author

GMishx commented Sep 5, 2019

well then why not updating the composer in the utils/install_composer.sh

I have bumped the composer version to 1.9.0 in the latest commit.

I tested it with PHP 5.6, 7.1 and 7.3 and it worked without any issue. Can you please test now?

@ag4ums ag4ums modified the milestones: 3.6.0, 3.7.0 Sep 5, 2019
@ag4ums ag4ums self-assigned this Sep 12, 2019
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
tested with debian buster working fine.

@ag4ums ag4ums merged commit abafc8f into fossology:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants