feat(api): Delete Copyright for a File #2478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
5 times, most recently
from
10463e9
to
d7d60d4
Compare
GMishx
added
needs code review
needs test
GSOC-23
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
2 times, most recently
from
bf3bc5a
to
38b95e8
Compare
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
from
38b95e8
to
b66089b
Compare
GMishx
requested changes
Jun 29, 2023
GMishx
reviewed
Jun 29, 2023
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
from
b66089b
to
9a8f179
Compare
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
from
9a8f179
to
8414f57
Compare
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
2 times, most recently
from
a4cfa40
to
4386ed7
Compare
|
Made the requested changes @GMishx Please do let me know if any more changes are required |
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
from
4386ed7
to
16b13d1
Compare
GMishx
requested changes
Jun 30, 2023
soham4abc
force-pushed
the
api/DeleteFileCopyrights
branch
from
16b13d1
to
75c9868
Compare
GMishx
approved these changes
Jul 3, 2023
|
@GMishx should I be removing the test case as of now?? |
|
Sure @soham4abc , you can remove test cases. And please rebase the branch for merge. |
GMishx
force-pushed
the
api/DeleteFileCopyrights
branch
from
3751c48
to
bec422b
Compare
|
Closing the branch as merged with 6015f62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletes a copyright for a file using
/file/upload/<uploadId>/item/<ItemId>/copyright/<Hash>Screenshot
@GMishx
@shaheemazmalmmd
closes #2468
Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)