Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get removable folder contents #2551

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jul 26, 2023

Description

Added the API to retrieve the get a list of removable contents in a folder.

Changes

  1. Added a new method in FolderController to build the functionality.
  2. Updated the main file(index.php) by adding a new route GET /folders/{id}/contents/removable.
  3. Updated the openapi.yaml file to write the new API's documentation.

How to test

Make a GET request on the endpoint: /folders/{id}/contents/removable.

Screenshots

image

Related Issue:

Fixes #2540

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jul 26, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Sep 12, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has merge conflicts PR to be rebased label Sep 28, 2023
dushimsam and others added 2 commits October 3, 2023 10:17
Signed-off-by: dushimsam <dushsam@gmail.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Tested, working as expected.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Oct 3, 2023
@GMishx GMishx merged commit c05727a into fossology:master Oct 3, 2023
13 checks passed
@GMishx GMishx deleted the get-removable-contents branch October 3, 2023 05:59
GMishx added a commit to siemens/fossology that referenced this pull request Oct 6, 2023
Ibrahim-Muhammad13 pushed a commit to Ibrahim-Muhammad13/fossology that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create REST API to unlink the folder
2 participants