Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get banner message #2553

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

soham4abc
Copy link
Contributor

@soham4abc soham4abc commented Jul 26, 2023

Description

Get banner message for all the users.

How to test

Send a GET response to /customise/banner endpoint.

Screenshots

image

@GMishx @shaheemazmalmmd @avinal

Fixes #2519

NOTE: Do not merge this before merging #2520

@soham4abc
Copy link
Contributor Author

As per the discussion HTML response could be sent but that would limit the customization on the new front-end if required.
If still required I would be modifying the response to send a HTML response.

@GMishx GMishx added the GSOC-23 Label to tag pull request which are part of the GSOC 2023 label Jul 28, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Aug 8, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Sep 28, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

soham4abc and others added 2 commits October 3, 2023 11:45
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Oct 3, 2023
@GMishx GMishx merged commit 8e1a41a into fossology:master Oct 3, 2023
13 checks passed
@GMishx GMishx deleted the api/getBanner branch October 3, 2023 07:16
GMishx added a commit to siemens/fossology that referenced this pull request Oct 6, 2023
Ibrahim-Muhammad13 pushed a commit to Ibrahim-Muhammad13/fossology that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize
3 participants