Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login button alignment issue #175

Closed
mayank2021 opened this issue Feb 17, 2022 · 6 comments · Fixed by #177
Closed

Login button alignment issue #175

mayank2021 opened this issue Feb 17, 2022 · 6 comments · Fixed by #177
Assignees
@mayank2021
Labels
bug Something isn't working

Comments

@mayank2021
Copy link
Contributor

Description

login button is not perfectly aligned with input elements

Current situation

image

Expected result

image
@mayank2021 mayank2021 added the bug Something isn't working label Feb 17, 2022
@mayank2021
Copy link
Contributor Author

@Shruti3004 @GMishx Can I take this up?

@GMishx
Copy link
Member

GMishx commented Feb 17, 2022

Sure

@soham4abc
Copy link
Contributor

soham4abc commented Feb 17, 2022 •
edited
Loading

@GMishx I already had this fixed :'-)

Desktop View

image

Mobile View

image

Should I create a PR?

@GMishx
Copy link
Member

GMishx commented Feb 17, 2022 •
edited
Loading

If the change is limited to the layout then please create the PR @soham4abc

@soham4abc
Copy link
Contributor

If the change is limited to the layout then please create the PR @soham4abc

on it

This was referenced Feb 17, 2022
Closed
Merged
@mayank2021
Copy link
Contributor Author

mayank2021 commented Feb 17, 2022 •
edited
Loading

@GMishx @soham4abc don't you think the desktop UI & mobile UI should have the equal spaces between all the element

like the image given below
image

image

I am done with the code @GMishx if @soham4abc can fix the issue than it's good otherwise please let me know just need to create a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayank2021 mayank2021

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): login button alignment fixed
3 participants
@GMishx @mayank2021 @soham4abc