Item13897: Intermidiate, converted checkers.

Also some improvements to error handling has been done. Trying to get rid
of as much of eval's as possible in cases where it's used to load a module.

- Another significat change is introduction of attrs attribute on
Foswiki::Configure::Item objects. It is used to hold all serializable keys
– i.e. those which names are not started with underscore. This is somewhat
of a headache across the Configure code because previously all keys were
stored directly on the object hash. Now non-serializable keys must have
their own attributes (like _parent, for instance). For example, old code:

$item->{serializable}
$item->{_nonserializable}

must be replaced with:

$item->attrs->{serializable}
$item->_nonserializable

Perhaps the children key shall get its own attribute too but I left it for
later.

- Moved redirect() method to Foswiki::App.

- Improved Foswiki::Config localization code by localizing not only data
but files and urlHost attributes too.

- Added TO_JSON method to Foswiki::Exception to take care of cases when
eval hides a thrown exception and interprets it as a response for a JsonRPC
request. This happened to Store::Implementation checker code leading to
JSON failing to encode response object.

- Added Foswiki::Exception::errorStr static method to convert an error
object of unknown type (i.e. a string from die, or a Foswiki::Exception or
Error descendants) into a plain string. For blessed references it is using
stringify or text methods in the order given.

- Fixed a bug in store encoding checked which was causing a regexp match
agains unitialized {Store}{Encoding} key during bootstrapping stage.

CommentPlugin/lib/Foswiki/Configure/Checkers/Plugins/CommentPlugin/GuestCanComment.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::CommentPlugin::GuestCanComment;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my $this = shift;

CommentPlugin/lib/Foswiki/Configure/Checkers/Plugins/CommentPlugin/RequiredForSave.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::CommentPlugin::RequiredForSave;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my $this = shift;

CompareRevisionsAddOn/lib/Foswiki/Configure/Checkers/Plugins/CompareRevisionsAddonPlugin/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::CompareRevisionsAddonPlugin::Enabled;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my ( $this, $value ) = @_;

CompareRevisionsAddOn/lib/Foswiki/Configure/Checkers/SwitchBoard/compareauth.pm

@@ -1,12 +1,12 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::SwitchBoard::compareauth;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
 use File::Spec();
-our @ISA = qw( Foswiki::Configure::Checker );
+
+use Moo;
+use namespace::clean;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this  = shift;

EditRowPlugin/lib/Foswiki/Configure/Checkers/Plugins/EditRowPlugin/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::EditRowPlugin::Enabled;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my ( $this, $value ) = @_;

EditRowPlugin/lib/Foswiki/Configure/Checkers/Plugins/EditRowPlugin/Macro.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::EditRowPlugin::Macro;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my ( $this, $value ) = @_;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/JQueryVersion.pm

@@ -1,12 +1,12 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::JQueryVersion;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
 use File::Spec();
-our @ISA = qw( Foswiki::Configure::Checker );
+
+use Moo;
+use namespace::clean;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this      = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Autocomplete/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Autocomplete::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Bgiframe/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Bgiframe::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Corner/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Corner::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Gradient/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Gradient::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Media/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Media::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Nifty/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Nifty::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Rating/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Rating::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Shake/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Shake::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/SimpleModal/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::SimpleModal::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Supersubs/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Supersubs::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Tmpl/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Tmpl::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Configure/Checkers/JQueryPlugin/Plugins/Tooltip/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::JQueryPlugin::Plugins::Tooltip::Enabled;
+use v5.14;
 
-use warnings;
-use strict;
-
-use Foswiki::Configure::Checker ();
-our @ISA = qw( Foswiki::Configure::Checker );
+use Moo;
+extends qw( Foswiki::Configure::Checker );
 
 sub check {
     my $this = shift;

JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/Plugins.pm

@@ -4,6 +4,7 @@ package Foswiki::Plugins::JQueryPlugin::Plugins;
 use strict;
 use warnings;
 use Foswiki::Func();
+use Try::Tiny;
 
 my @iconSearchPath;
 my %iconCache;
@@ -282,17 +283,28 @@ sub load {
 
     unless ( defined $pluginDesc->{instance} ) {
 
-        eval "require $pluginDesc->{class};";
-
-        if ($@) {
-            Foswiki::Func::writeDebug(
-                "ERROR: can't load jQuery plugin $pluginName: $@");
-            $pluginDesc->{instance} = 0;
-        }
-        else {
+        try {
+            Foswiki::load_class( $pluginDesc->{class} );
             $pluginDesc->{instance} =
               $Foswiki::app->create( $pluginDesc->{class} );
         }
+        catch {
+            my $errStr = Foswiki::Exception::errorStr($_);
+            Foswiki::Func::writeDebug(
+                "ERROR: can't load jQuery plugin $pluginName: $errStr");
+            $pluginDesc->{instance} = 0;
+        };
+
+        #eval "require $pluginDesc->{class};";
+        #if ($@) {
+        #    Foswiki::Func::writeDebug(
+        #        "ERROR: can't load jQuery plugin $pluginName: $@");
+        #    $pluginDesc->{instance} = 0;
+        #}
+        #else {
+        #    $pluginDesc->{instance} =
+        #      $Foswiki::app->create( $pluginDesc->{class} );
+        #}
     }
 
     return $pluginDesc->{instance};

JsonRpcContrib/lib/Foswiki/Contrib/JsonRpcContrib/Response.pm

@@ -32,10 +32,13 @@ has id      => ( is => 'rw', );
 has message => ( is => 'rw', );
 has code    => ( is => 'rw', lazy => 1, default => 0, );
 has json => (
-    is      => 'rw',
+    is      => 'ro',
     lazy    => 1,
     default => sub {
-        return JSON->new->pretty(DEBUG)->convert_blessed(1);
+        my $json = JSON->new;
+        $json->pretty(DEBUG);
+        $json->convert_blessed(1);
+        return $json;
     },
 );
 

MailerContrib/lib/Foswiki/Configure/Checkers/Plugins/MailerContribPlugin/Enabled.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::MailerContribPlugin::Enabled;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my ( $this, $value ) = @_;

MailerContrib/lib/Foswiki/Configure/Checkers/Plugins/MailerContribPlugin/Module.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Plugins::MailerContribPlugin::Module;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 sub check {
     my ( $this, $value ) = @_;

PlainFileStoreContrib/lib/Foswiki/Configure/Checkers/Extensions/PlainFileStoreContrib/CheckForRCS.pm

@@ -1,11 +1,9 @@
 # See bottom of file for license and copyright information
 package Foswiki::Configure::Checkers::Extensions::PlainFileStoreContrib::CheckForRCS;
+use v5.14;
 
-use strict;
-use warnings;
-
-use Foswiki::Configure::Checker ();
-our @ISA = ('Foswiki::Configure::Checker');
+use Moo;
+extends qw(Foswiki::Configure::Checker);
 
 my @required = (