Item12952: turn off trace, and improve test .spec

foswiki · Sep 12, 2014 · 577e0e9 · 577e0e9
1 parent 92abf3a
commit 577e0e9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/lib/Foswiki/Plugins/ConfigurePlugin.pm b/lib/Foswiki/Plugins/ConfigurePlugin.pm
@@ -38,7 +38,7 @@ our $SHORTDESCRIPTION = '=configure= interface using json-rpc';
 
 our $NO_PREFS_IN_TOPIC = 1;
 
-use constant TRACE => 1;
+use constant TRACE => 0;
 
 BEGIN {
     # Note: if Foswiki is in bootstrap mode, Foswiki.pm will try

diff --git a/lib/Foswiki/Plugins/ConfigurePlugin/Config.spec b/lib/Foswiki/Plugins/ConfigurePlugin/Config.spec
@@ -7,45 +7,56 @@
 # When you press the Test button, expect the value to change to "ROPE" and
 # there to be one each of the different levels of report.
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{STRING} = 'STRING';
-# **PASSWORD**
-$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{PASSWORD} = 'PASSWORD';
 # **BOOLEAN**
+# Should be 1
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{BOOLEAN} = 1;
 # **COMMAND**
+# Should be COMMAND
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{COMMAND} = 'COMMAND';
 # **DATE**
+# Should be 12 Feb 2012
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{DATE} = '12 Feb 2012';
 # **EMAILADDRESS**
+# Should be address@email.co
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{EMAILADDRESS} = 'address@email.co';
-# **LANGUAGE**
-$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{LANGUAGE} = 'LANGUAGE';
 # **NUMBER**
-$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{NUMBER} = '666';
+# Should be 666
+$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{NUMBER} = 666;
 # **OCTAL**
-$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{OCTAL} = 'OCTAL';
+# Should see 755
+$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{OCTAL} = 429;
 # **PASSWORD**
+# Shouldn't reflect
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{PASSWORD} = 'PASSWORD';
 # **PATH**
+# Should be PATH
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{PATH} = 'PATH';
 # **PERL**
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{PERL} = 'PERL';
 # **REGEX**
+# Should be /^regex$/
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{REGEX} = qr/^regex$/;
 # **SELECTCLASS none,Foswiki::Confi* **
+# Should be Foswiki::Configure
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{SELECTCLASS} = 'Foswiki::Configure';
-# **SELECT**
-$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{SELECT} = 'SELECT';
+# **SELECT choose,life**
+# Should be life
+$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{SELECT} = 'life';
 # **URLPATH**
+# Should be /
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{URLPATH} = '/';
 # **URL**
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{URL} = 'http://localhost';
 # **STRING H**
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{H} = 'H';
 # **STRING EXPERT**
+# Should be EXPERT
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{EXPERT} = 'EXPERT';
 # **PATH**
+# Should be 'empty'
 # $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{empty} = 'empty';
 # **STRING**
+# Should be a list of other items
 $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{DEPENDS} = '$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{H} and $Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{EXPERT} ans $$Foswiki::cfg{Plugins}{ConfigurePlugin}{Test}{NotPresent}';