Item13894: Foswiki::decode does not decode in-place, so can't replace…

… utf8::upgrade
foswiki · Dec 14, 2015 · a81649b · a81649b
1 parent dcf8bc6
commit a81649b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/RCSStoreContrib/lib/Foswiki/Store/Rcs/Store.pm b/RCSStoreContrib/lib/Foswiki/Store/Rcs/Store.pm
@@ -291,7 +291,7 @@ sub getRevisionDiff {
       $rcs->revisionDiff( $topicObject->getLoadedRev(), $rev2, $contextLines );
     foreach my $d (@$diffs) {
         foreach my $i ( 1, 2 ) {
-            _decode( $d->[$i] );
+            $d->[$i] = _decode( $d->[$i] );
         }
     }
     return $diffs;
@@ -331,8 +331,8 @@ sub _getAttachmentVersionInfo {
           $this->getHandler( $topicObject->web, $topicObject->topic,
             $attachment );
         $info = $handler->getInfo( $rev || 0 );
-        _decode( $info->{author} );
-        _decode( $info->{comment} );
+        $info->{author} = _decode( $info->{author} );
+        $info->{comment} = _decode( $info->{comment} );
     }
 
     return $info;
@@ -368,8 +368,8 @@ sub getVersionInfo {
         my $handler =
           $this->getHandler( $topicObject->web, $topicObject->topic );
         $info = $handler->getInfo($rev);
-        _decode( $info->{author} );
-        _decode( $info->{comment} );
+        $info->{author} = _decode( $info->{author} );
+        $info->{comment} = _decode( $info->{comment} );
     }
 
     # make sure there's at least author, date and version