Skip to content

Commit

Permalink
Item2191: add 2 TODO's as there really isn't enough work done in this…
Browse files Browse the repository at this point in the history
… code

git-svn-id: http://svn.foswiki.org/trunk@5226 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
SvenDowideit authored and SvenDowideit committed Oct 7, 2009
1 parent f985c0f commit a929e0c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion core/lib/Foswiki/UI/Register.pm
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ my %SKIPKEYS = (
'Confirm' => 1,
'Email' => 1
);
my @requiredFields = qw(WikiName FirstName LastName Email);


=begin TML
Expand Down Expand Up @@ -187,6 +189,8 @@ sub bulkRegister {
}

my $log = "---+ Report for Bulk Register\n";
#TODO: should check that the header row actually contains the required fields.
#TODO: and consider using MAKETEXT to enable translated tables.

#-- Process each row, generate a log as we go
for ( my $n = 0 ; $n < scalar(@data) ; $n++ ) {
Expand Down Expand Up @@ -238,7 +242,6 @@ sub _registerSingleBulkUser {

#-- Ensure every required field exists
# NB. LoginName is OPTIONAL
my @requiredFields = qw(WikiName FirstName LastName Email);
if ( _missingElements( $fieldNames, \@requiredFields ) ) {
$log .=
$b1
Expand Down

0 comments on commit a929e0c

Please sign in to comment.