-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal Ruler Helper - Outlook compatible #716
Comments
This is cool! Can you do a PR for this? |
@DerekBess This is a great add. Definitely put in a PR for this. |
@canterberrie @davehoran thanks, still got a few little tweaks to make. How do you do a PR? |
@IamManchanda thank you for that. I'll mess around with it this week. |
@canterberrie @davehoran @IamManchanda I just added the pull request. Hopefully I did it right but looks like I had to do it on the foundation-emails-template repository. |
@DerekBess commented 4 hours ago
@DerekBess commented 2 hours ago
That's interesting, so your 1 week was just 2 hours short 😈 |
@IamManchanda lol, thanks. I'm still trying to get the hang of how the flow works with the requests. |
Really cool @DerekBess - however just curious, why not use inky?
And then style the spacer so width isn't 100% and background-color is what you desire. Didn't review the pull request, but I'd think it would be ideal to patch the inky syntax with new attributes you're suggesting (color, width, spacing). I also never liked "size" as an attribute for |
@stevesmename I'll test out spacer tag this weekend when I get some free time. I believe the issue is going to be the spacer tag will not be as flexible as the helper I created when it comes to outlook. I tried to make it as email client friendly as possible which means sacrificing additional markup for optimization but that's the way the cookie crumbles with MSO :( |
@DerekBess I used the helper tag for a campaign I put together yesterday. Worked great. Thanks again for the code! @stevesmename I used to use a styled spacer element for this, then switched to a modified tag. That said, @DerekBess solution is much smoother. |
@davehoran sweet! Glad to hear someone has actually used it other then myself. I have used it in three separate client projects and I have yet to come across any type of styling issues as of yet. We could consolidate the markup if it weren't for pesky mso! |
Works great, but it isn't centered in Yahoo! webmail. The line gets justified to the left. |
@elliottregan Thanks for the taking the time to test my helper. I'll be honest, I haven't had a whole lot of time to get back to this as I'm working on a project at the moment. I'll get back to this soon though and I'll test this with Email on Acid to see what needs to happen. I'll investigate how we can get the ruler to align properly on Yahoo mail client. If you have any suggestions, fixes or workarounds to make this happen, please let me know so I can modify the helper to improve client support. Thanks again and take care! |
I'm working on another email project right now so I'll investigate this issue and see what needs to be done to correct it. |
Created another useful helper that I'm sharing the community here. This is a nice way to add a horizontal ruler to your email template. Create file named "ruler.js" and place it in your helper folder.
Paste this code in the ruler.js file you created.
Then all you need to do is use this handlebar:
{{{ruler color="#009F8C" width="60" height="3" spacing="20"}}}
Spacing is above and below the ruler. You can leave it blank if you do not wish to have spacing before and after the ruler.
Here is an example of one of the templates I'm working on so you can see how it looks. Basically, it's the little rulers between the headline and sub headline text.
Hope you all enjoy and let me know if you have better solution as well because I really suck at javascript and coding in general :)
The text was updated successfully, but these errors were encountered: