Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Base-level rules cannot contain the parent-selector-referencing character '&' #10279

Closed
heidkaemper opened this issue Jun 28, 2017 · 6 comments
Assignees

Comments

@heidkaemper
Copy link

I try to use Foundation 6.4 (sass) with xy grid.

Error message:

Error: Base-level rules cannot contain the parent-selector-referencing character &. on line 311 of lib/foundation/scss/xy-grid/_classes.scss, in xy-vertical-grid-classes from line 449 of lib/foundation/scss/xy-grid/_classes.scss, in foundation-xy-grid-classes from line 10 of css/main.scss

System:

Windows 10
Ruby
Sass 3.4.24

@kball
Copy link
Contributor

kball commented Jun 28, 2017

Interesting, this appears to be a real bug, but node-scss did not catch it (silently doing the "right thing" by outputting a top level class). Putting together a PR to fix it, we'll get out a patch release soon once we have any more items like this straightened out

@coetry
Copy link

coetry commented Jun 28, 2017

The same thing happens on line 65 and 69 of /scss/components/_accordion-menu.scss in 'zf-accordion-menu-left-right-arrows'

@kball
Copy link
Contributor

kball commented Jun 28, 2017

@coetry good catch... @IamManchanda @brettsmason within drilldown and dropdown the arrows are included only within parent classes (.drilldown and .is-dropdown-submenu-parent respectively)... do you think that should be the case for accordion menu as well?

@IamManchanda
Copy link
Contributor

Yes it should be ... let me see! @kball

@IamManchanda IamManchanda self-assigned this Jun 28, 2017
kball added a commit that referenced this issue Jun 28, 2017
Fix issue #10279 by removing mistaken '&' for top level selector
@GenieTim
Copy link

I am facing the same issue. What do I have to do to get npm to fetch the newest, fixed version?
npm update seems not to be ready yet...

@kball
Copy link
Contributor

kball commented Jun 29, 2017

We're going to package up fixes for this and a couple others either later today or early tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants