Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve dropdown menu accessibility - closes #8810 #11956

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix: improve dropdown menu accessibility - closes #8810 #11956

merged 1 commit into from
Mar 27, 2020

Conversation

Niznikr
Copy link
Contributor

@Niznikr Niznikr commented Jan 2, 2020 •
edited
Loading

Description

This addresses #8810. Updates list item role to none and adds role menuitem to anchors within the menu. This enables proper keyboard navigation when using a screen reader.

Note: We currently use 6.4. It would be much appreciated if the change was backported to that release family.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@Niznikr
fix: improve dropdown menu accessibility
35a12f2 
Updates li and a element roles to the appropriate values.

Addresses foundation#8810

on-behalf-of: @ithaka <robert.niznik@ithaka.org>
@Niznikr Niznikr changed the title fix: improve dropdown menu accessibility - #8810 fix: improve dropdown menu accessibility - closes #8810 Jan 2, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jan 5, 2020
Closed
@Niznikr
Copy link
Contributor Author

Niznikr commented Jan 8, 2020 •
edited
Loading

@DanielRuf please let us know if we can help with anything to get this into a release!

@weekly-digest weekly-digest bot mentioned this pull request Jan 12, 2020
Closed
joeworkman
joeworkman approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@joeworkman joeworkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what Daniel thinks...

@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@joeworkman joeworkman added this to the 6.6.2 milestone Mar 27, 2020
@joeworkman joeworkman merged commit d1477a6 into foundation:develop Mar 27, 2020
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-6-6-2/1936/1

This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
@AliceSof AliceSof mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeworkman joeworkman joeworkman approved these changes

@DanielRuf DanielRuf Awaiting requested review from DanielRuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.2
Development

Successfully merging this pull request may close these issues.

Accessibility issue with Dropdown
2 participants
@Niznikr @joeworkman