Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): dumpState / loadState on a forked anvil #4026

Closed
Maddiaa0 opened this issue Jan 3, 2023 · 2 comments
Closed

feat(anvil): dumpState / loadState on a forked anvil #4026

Maddiaa0 opened this issue Jan 3, 2023 · 2 comments
Assignees
Labels
C-anvil Command: anvil T-feature Type: feature

Comments

@Maddiaa0
Copy link
Contributor

Maddiaa0 commented Jan 3, 2023

Component

Anvil

Describe the feature you would like

Currently anvil has the capability to load and dump state to a file, enabling persistence. First introduced here: #3730.

At Aztec we have an in-house dev net running on an anvil mainnet fork. When adding the --state flag, it currently fails as state dumping is not yet implemented for the anvil fork_db back-end. I've naively hacked the functionality together here (see: https://github.com/cheethas/foundry/pull/1/files) and it appears to behave as I would expect.

If the above is satisfactory I can open a pull request iterating on my naive solution, however I thought I'd first ask in an issue, as I think there's big gotchas I've overlooked which led to it not being implemented in the pr above.

Additional context

N/A

@Maddiaa0 Maddiaa0 added the T-feature Type: feature label Jan 3, 2023
@mattsse
Copy link
Member

mattsse commented Jan 3, 2023

right, this is indeed missing, and we should include this.

please submit a PR here so we can review and get it merged.

from what I can tell, this looks pretty good already

@Maddiaa0
Copy link
Contributor Author

Maddiaa0 commented Jan 4, 2023

closed by #4027

@Maddiaa0 Maddiaa0 closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-anvil Command: anvil T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

3 participants