Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil API test - can_remove_pool_transactions fails on master #7645

Closed
2 tasks done
Tracked by #8269
mw2000 opened this issue Apr 12, 2024 · 4 comments
Closed
2 tasks done
Tracked by #8269

Anvil API test - can_remove_pool_transactions fails on master #7645

mw2000 opened this issue Apr 12, 2024 · 4 comments
Labels
C-anvil Command: anvil T-bug Type: bug

Comments

@mw2000
Copy link
Contributor

mw2000 commented Apr 12, 2024

Component

Anvil

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

cargo test anvil

Operating System

macOS (Apple Silicon)

Describe the bug

The anvil API test can_remove_pool_transactions is failing on the master branch. This is testing whether there is an initial pending transaction present.

@mw2000 mw2000 added the T-bug Type: bug label Apr 12, 2024
@mattsse
Copy link
Member

mattsse commented Apr 12, 2024

cc @yash-atreya

@yash-atreya
Copy link
Member

@mw2000 I'm unable to reproduce this, it's working for me on the latest commit bdc04c2. Anyways, we're migrating this code to Alloy currently.

@mw2000
Copy link
Contributor Author

mw2000 commented Apr 12, 2024

@yash-atreya just double checked commits and it seems to still be failing on the bdc04c2 commit for me. No worries if not able to reproduce and have future plans to migrate to alloy.

For more context, it fails at:

https://github.com/foundry-rs/foundry/blob/master/crates/anvil/tests/it/anvil_api.rs#L652

The error I get on my end:

---- anvil_api::can_remove_pool_transactions stdout ----
thread 'anvil_api::can_remove_pool_transactions' panicked at crates/anvil/tests/it/anvil_api.rs:652:5:
assertion `left == right` failed
  left: 0
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    anvil_api::can_remove_pool_transactions

test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 146 filtered out; finished in 4.52s

@zerosnacks
Copy link
Member

Marking as resolved as these tests have been passing since the migration to Alloy

Feel free to re-open if you are still experiencing issues with this @mw2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-anvil Command: anvil T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

4 participants