[#2528] Add categories to languages #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbron
force-pushed
the
language-categories
branch
from
955650d
to
369a7cb
Compare
krbz999
reviewed
Nov 9, 2023
56 tasks
Fyorl
requested changes
Nov 13, 2023
|
|
||
| return key; | ||
| // Explicit categories (e.g. languages) |
There was a problem hiding this comment.
Not clear to me how this differs from the above tool options where we search for an exact category match or a child match? Do we still need those, or are they covered by this new searchCategory?
There was a problem hiding this comment.
For vehicle categories in tools, those are stored in separate configuration objects, while these are nested categories in a single object. The joys of years of legacy configuration data :).
There was a problem hiding this comment.
Got it, thanks, that makes sense.
Fyorl
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups languages into categories based on how they are defined in the SRD.
This change does modify the
languagesobject in config, but it shouldn't be a breaking change for most cases because adding languages in the old fashion (CONFIG.DND5E.languages.test = "test";) will still work correctly (those languages will just appear at the top level.Retrieving languages using
Trait.keyLabelwill also continue working. The only case that will lead to unexpected results is if code was retrieving languages directly (console.log(CONFIG.DND5E.languages.common), but that will just return empty.