Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compendium browser support dual language search #14068

Closed
bb46003 opened this issue Mar 5, 2024 · 3 comments · Fixed by #14121
Closed

Compendium browser support dual language search #14068

bb46003 opened this issue Mar 5, 2024 · 3 comments · Fixed by #14121
Labels
feature request not actionable This issue has insufficient information to be addressed

Comments

@bb46003
Copy link

bb46003 commented Mar 5, 2024

Please consider add option to combpendium browser to allow serch in local language and oryginal.
It can be easly achive by adding for each tab in compendium-browser/tab file three changes

searchFields=["name","oryginalname"];
storeFields=["type","name","img","uuid","level","category","group","price","priceInCopper","traits","rarity","source", "oryginalname"]

this in searchfiels and storeFields on end I add variable "oryginalneme" and third place were all those data are asigne we need this


inventoryItems.push({
type:itemData.type,
name:itemData.name,
img:itemData.img,
uuid:`Compendium.${pack.collection}.${itemData._id}`,
level:itemData.system.level?.value 0,
category:itemData.system.category??"",
group:itemData.system.group??"",
price:priceCoins,
priceInCopper:coinValue,
traits:uniq(itemData.system.traits.value),
rarity:itemData.system.traits.rarity,
source:sourceSlug, 
oryginalname:itemData.originalName}) 

This will support all local language and have no effect for users wich out translation module

@stwlam
Copy link
Collaborator

stwlam commented Mar 8, 2024

What prevents this now?

@stwlam stwlam added feature request not actionable This issue has insufficient information to be addressed labels Mar 8, 2024
@bb46003
Copy link
Author

bb46003 commented Mar 8, 2024

Macro compendium browser use in search only item name, if it is localize then it is impossible to search by English, of course Foundry compendium search works, but all places like buttons magnifying glas on character sheet not allow to search using English. Combine localize and english name by language modules brake other things like adding rune name to weapon

@bb46003
Copy link
Author

bb46003 commented Mar 8, 2024

For example:

obraz

obraz

But those are results WITH proposal changes, with out them first example fill not show anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request not actionable This issue has insufficient information to be addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants