[BUG] MeasuredTemplatePF2e get snappingMode returns incorrect snapmodes on Hex Grid

[FolkvangrForgent]

As a residence hex grid user I was tracking down odd snapping behavior of template on hex grids. It looks like the get snappingMode function in MeasuredTemplatePF2e is written with the expectation that it is called from a square grid but it can also be called from a hex grid via the chat message button. As far as I can tell it still can't be called from gridless.

I would suggest replacing the current code:

pf2e/src/module/canvas/measured-template.ts

Lines 34 to 45 in 6e63427

	switch (this.areaShape) {
	case "burst":
	return M.CORNER;
	case "emanation":
	return M.CENTER;
	case "cone":
	return M.CENTER | M.CORNER | M.SIDE_MIDPOINT;
	case "line":
	return M.SIDE_MIDPOINT | M.CORNER;
	default:
	return M.CENTER | M.CORNER;
	}

with something like the following code:

        if (canvas.grid.isSquare) {
            switch (this.areaShape) {
                case "burst":
                    return M.CORNER;
                case "emanation":
                    return M.CENTER;
                case "cone":
                    return M.CENTER | M.CORNER | M.SIDE_MIDPOINT;
                case "line":
                    return M.SIDE_MIDPOINT | M.CORNER;
                default:
                    return M.CENTER | M.CORNER;
            }
        }
        if (canvas.grid.isHexagonal) {
            switch (this.areaShape) {
                case "burst":
                    return M.VERTEX;
                case "emanation":
                    return M.CENTER;
                case "cone":
                    return M.CENTER | M.VERTEX;
                case "line":
                    return M.CENTER;
                default:
                    return M.CENTER | M.VERTEX;
            }
        }

(I'll admit that I have left the "cone" to the default of M.CENTER | M.VERTEX as I do not know if a more restrictive set of modes would be cleaner for hex grids)

Additionally with the snappingMode working on hex grids the following code:

pf2e/src/module/canvas/layer/template.ts

Line 19 in 6e63427

if (!template || !canvas.grid.isSquare) {

can be changed to:

        if (!template || canvas.grid.isGridless) { 

I will lastly note that there is a current MR #15552 that add more square grid dependent logic.

[FolkvangrForgent]

As another suggestion of code cleanup the function hasHexGrid that is part of ScenePF2e is redundant with the new isHexagonal grid flag. The following code can be removed:

pf2e/src/module/scene/document.ts

Lines 50 to 53 in 6e63427

	get hasHexGrid(): boolean {
	const squareOrGridless: number[] = [CONST.GRID_TYPES.GRIDLESS, CONST.GRID_TYPES.SQUARE];
	return !squareOrGridless.includes(this.grid.type);
	}

if the three references to canvas.scene.hasHexGrid are changed to canvas.scene.grid.isHexagonal. I have linked the references below for quick access:

pf2e/src/scripts/hooks/canvas-ready.ts

Line 32 in 6e63427

CONFIG.MeasuredTemplate.defaults.angle = canvas.scene.hasHexGrid ? 60 : 90;

pf2e/src/module/canvas/layer/template.ts

Line 55 in 6e63427

const snapAngle = Math.PI / (canvas.scene.hasHexGrid ? 6 : 4);

pf2e/src/module/canvas/layer/template.ts

Line 79 in 6e63427

const coneMultiplier = shapeType === "cone" ? (canvas.scene.hasHexGrid ? 2 : 3) : 1;