Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finesse weapons not applying damage correctly #2

Closed
cswendrowski opened this issue Aug 13, 2019 · 12 comments
Closed

Finesse weapons not applying damage correctly #2

cswendrowski opened this issue Aug 13, 2019 · 12 comments

Comments

@cswendrowski
Copy link

In GitLab by @hooking on Aug 13, 2019, 02:29

Current implementation is using the dnd5e method of adding DEX mod to damage when using DEX for attack rolls.

PF2e should use STR mod in all cases except when:

  • a feat, trait or class feature overwrites this rule
    -- i.e. the Thief racket OR the Propulsive weapon trait.
@cswendrowski
Copy link
Author

In GitLab by @hooking on Aug 13, 2019, 05:14

Forced damage to use STR and added support for ranged weapon damage rolls including thrown and propulsive traits.

@cswendrowski
Copy link
Author

In GitLab by @hooking on Aug 13, 2019, 05:14

closed

@cswendrowski
Copy link
Author

In GitLab by @overdox on May 17, 2020, 18:02

mentioned in commit 5f13542

@cswendrowski
Copy link
Author

In GitLab by @overdox on Jun 9, 2020, 17:00

mentioned in commit f690ef2

@cswendrowski
Copy link
Author

In GitLab by @tmun on Sep 1, 2020, 23:55

mentioned in commit 9d5acdf

@cswendrowski
Copy link
Author

In GitLab by @nikolaj-a on Sep 1, 2020, 23:59

mentioned in commit e42af67

@cswendrowski
Copy link
Author

In GitLab by @krazmuze on Nov 30, 2020, 01:51

This is not fixed when rolling dmg from inventory tab, only when rolling dmg from action tab

@cswendrowski
Copy link
Author

In GitLab by @tmun on Nov 30, 2020, 08:16

Damage code from the inventory tab doesn’t use the right code. It exists for legacy reasons and will be removed very shortly. (Note that in the last release strikes are no longer labelled “experimental”)

@cswendrowski
Copy link
Author

In GitLab by @krazmuze on Nov 30, 2020, 11:39

I think the inventory screen is useful but removing it will make it
consistent. One problem with strikes is it does not show which weapon is
equipped so there is still reason to use inventory screen. If inventory
screen is removed have the equipped reflected on the strikes screen.

@cswendrowski
Copy link
Author

In GitLab by @overdox on Apr 6, 2021, 17:35

mentioned in commit 30aaf88

@cswendrowski
Copy link
Author

In GitLab by @tmun on Jun 6, 2021, 11:14

mentioned in commit 59b9b88

@cswendrowski
Copy link
Author

In GitLab by @stwlam on Jan 18, 2022, 04:52

mentioned in commit 67bb267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant