Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yarn v3 #866

Merged
merged 1 commit into from Mar 27, 2023
Merged

Upgrade to Yarn v3 #866

merged 1 commit into from Mar 27, 2023

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Mar 27, 2023

Public-Facing Changes

N/A

Description

Upgrade to Yarn v3 for consistency with other repos.

@amacneil amacneil force-pushed the adrian/yarn3 branch 4 times, most recently from 0ba3bf0 to 99aa256 Compare March 27, 2023 03:48
package.json Outdated
@@ -22,5 +22,6 @@
"prettier": "^2.8.4",
"tailwindcss": "^3.2.7",
"typedoc": "^0.23.25"
}
},
"packageManager": "yarn@3.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we are using corepack? Does using corepack mean we could get rid of the .yarn/releases/yarn-3.5.0.cjs that we check in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are right! I assumed it would not be possible since none of our other repos do that. But I just tested it and seems to work great.

Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 still haven't seen what the real benefit of using yarn v3 is. I think adrianbot has several other TS repos it needs to update next 🙌

@amacneil amacneil force-pushed the adrian/yarn3 branch 4 times, most recently from e830052 to 4922418 Compare March 27, 2023 22:17
@amacneil amacneil merged commit 4b16caf into main Mar 27, 2023
27 checks passed
@amacneil amacneil deleted the adrian/yarn3 branch March 27, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants