Send ROS_DISTRO to clients via metadata field #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
commented
Jan 12, 2023
| @@ -194,6 +194,7 @@ class Server final : public ServerInterface { | |||
| explicit Server(std::string name, LogCallback logger, | |||
| const std::vector<std::string>& capabilities, | |||
| const std::vector<std::string>& supportedEncodings = {}, | |||
| const std::unordered_map<std::string, std::string>& metadata = {}, | |||
There was a problem hiding this comment.
For simplicity, I decided to make this a map of string-string pairs. When e.g. using std::variant, we would have to provide json conversions for it.
There was a problem hiding this comment.
I made an indifferent comment on the spec PR, but after seeing this I think we should change the spec to <string, string>
jhurliman
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
$ROS_DISTROto clients viaserverInfo'smetadatafieldDescription
serverInfo'smetadatafield (Spec: Allow to send additional metadata to clients ws-protocol#334)$ROS_DISTROenvironment variable via themetadatafieldBlocked by foxglove/ws-protocol#334