Spec: Allow to send additional metadata to clients #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Jan 11, 2023
achim-k
commented
Jan 12, 2023
achim-k
changed the title
achim-k
force-pushed
the
achim/server_info_options
branch
from
e8c8c96
to
35fdefd
Compare
jhurliman
approved these changes
Jan 12, 2023
jhurliman
reviewed
Jan 12, 2023
achim-k
added a commit
to foxglove/ros-foxglove-bridge
that referenced
this pull request
Jan 13, 2023
**Public-Facing Changes** - Send current `$ROS_DISTRO` to clients via `serverInfo`'s `metadata` field **Description** - Add support for `serverInfo`'s `metadata` field (foxglove/ws-protocol#334) - Inform clients about the value of the `$ROS_DISTRO` environment variable via the `metadata` field Blocked by foxglove/ws-protocol#334
pezy
pushed a commit
to pezy/ws-protocol
that referenced
this pull request
Jul 27, 2023
**Public-Facing Changes** - Allow to send additional server options to clients **Description** Allows to inform clients about additional server options. E.g. for [foxglove-bridge ](https://github.com/foxglove/ros-foxglove-bridge) we would like to communicate the ROS_DISTRO to the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Allows to inform clients about additional server options. E.g. for foxglove-bridge we would like to communicate the ROS_DISTRO to the client