Types with same name are mixed up

[jobafr]

Description
When parsing multiple types with the same name, such as visualization_msgs/Marker and aruco_msgs/Marker, the library mixes them up when they are used as children of another type.

• Version: 4.2.2 (I tested with several versions from 1.0.1 to 4.2.2 and the bug seems to be present in all of them)
• Platform: Linux, ROS noetic (but this probably hits ROS2 too)

Steps To Reproduce

  let res = parse(`

MSG: visualization_msgs/Marker
int32 a

===
MSG: aruco_msgs/Marker
int32 b

===
MSG: visualization_msgs/MarkerArray
Marker[] a

===
MSG: aruco_msgs/MarkerArray
Marker[] b
  
  `, { ros2: false })

  console.log(JSON.stringify(res, undefined, 2));

Expected Behavior
aruco_msgs/MarkerArray should contain an array of aruco_msgs/Marker, not visualization_msgs/Marker.

[
  {
    "name": "visualization_msgs/Marker",
    "definitions": [
      {
        "type": "int32",
        "isArray": false,
        "name": "a",
        "isComplex": false
      }
    ]
  },
  {
    "name": "aruco_msgs/Marker",
    "definitions": [
      {
        "type": "int32",
        "isArray": false,
        "name": "b",
        "isComplex": false
      }
    ]
  },
  {
    "name": "visualization_msgs/MarkerArray",
    "definitions": [
      {
        "type": "visualization_msgs/Marker",
        "isArray": true,
        "name": "a",
        "isComplex": true
      }
    ]
  },
  {
    "name": "aruco_msgs/MarkerArray",
    "definitions": [
      {
        "type": "aruco_msgs/Marker",
        "isArray": true,
        "name": "b",
        "isComplex": true
      }
    ]
  }
]

Actual behavior
Both MarkerArray types contain an array of visualization_msgs/Marker.

[
  {
    "name": "visualization_msgs/Marker",
    "definitions": [
      {
        "type": "int32",
        "isArray": false,
        "name": "a",
        "isComplex": false
      }
    ]
  },
  {
    "name": "aruco_msgs/Marker",
    "definitions": [
      {
        "type": "int32",
        "isArray": false,
        "name": "b",
        "isComplex": false
      }
    ]
  },
  {
    "name": "visualization_msgs/MarkerArray",
    "definitions": [
      {
        "type": "visualization_msgs/Marker",
        "isArray": true,
        "name": "a",
        "isComplex": true
      }
    ]
  },
  {
    "name": "aruco_msgs/MarkerArray",
    "definitions": [
      {
        "type": "visualization_msgs/Marker",
        "isArray": true,
        "name": "b",
        "isComplex": true
      }
    ]
  }
]

[jtbandes]

Thanks for the report. Would you be interested in submitting a PR to fix this?

[defunctzombie]

Internal tracking ticket: https://linear.app/foxglove/issue/FG-5383/types-with-same-name-are-mixed-up