Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a frame_id field to LocationFix #108

Merged
merged 3 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,17 @@ const LocationFix: FoxgloveMessageSchema = {
name: "LocationFix",
description: "A navigation satellite fix for any Global Navigation Satellite System",
fields: [
{
name: "frame_id",
type: { type: "primitive", name: "string" },
description:
"Frame for the sensor. Latitude and longitude readings are at the origin of the frame.",
},
{
name: "timestamp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: every other schema has timestamp listed before frame_id

type: { type: "primitive", name: "time" },
description: "Timestamp of the message",
},
{
name: "latitude",
type: { type: "primitive", name: "float64" },
Expand Down
6 changes: 6 additions & 0 deletions ros_foxglove_msgs/ros1/LocationFix.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions ros_foxglove_msgs/ros2/LocationFix.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions schemas/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions schemas/flatbuffer/LocationFix.fbs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions schemas/jsonschema/LocationFix.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions schemas/jsonschema/index.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 13 additions & 5 deletions schemas/proto/foxglove/LocationFix.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions schemas/ros1/LocationFix.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions schemas/ros2/LocationFix.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions schemas/typescript/LocationFix.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.