Add CompressedVideo schema #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Aug 15, 2023
| { | ||
| name: "timestamp", | ||
| type: { type: "primitive", name: "time" }, | ||
| description: "Timestamp of image", |
There was a problem hiding this comment.
Why do we keep the "image" terminology here? Should this be "video frame" instead or something like that?
Closed
pezy
reviewed
Aug 17, 2023
| }, | ||
| ], | ||
| }; | ||
|
|
There was a problem hiding this comment.
Why are keyframe and metadata no longer needed here?
There was a problem hiding this comment.
these are no longer included because people often come from already having compressed video formatted streams and it would be too much of a heavylift for them to parse out this format-specific information and write it back to the message in a more accessible way. All of this information is included in the formatted data byte array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #114 for https://github.com/foxglove/studio/pull/6543