Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add frame_id to RawImage, CompressedImage, and CameraCalibration #61

Merged
merged 3 commits into from
Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions schemas/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/CameraCalibration.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/CompressedImage.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/RawImage.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/CameraCalibration.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/CompressedImage.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/RawImage.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/CameraCalibration.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/CompressedImage.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/RawImage.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions src/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,12 @@ Given a 3D point [X Y Z]', the projection (x, y) of the point onto the rectified
This holds for both images of a stereo pair.
`,
},
{
name: "frame_id",
type: { type: "primitive", name: "string" },
description:
"Frame of reference for the camera. The origin of the frame is the optical center of the camera. +x points to the right in the image, +y points down, and +z points into the plane of the image.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth calling out that CameraCalibration should be in the same frame as its corresponding image? What happens if the CameraCalibration is a different frame?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea really. Probably bad things.

},
],
};

Expand All @@ -764,6 +770,12 @@ const CompressedImage: FoxgloveMessageSchema = {
type: { type: "primitive", name: "string" },
description: "Image format",
},
{
name: "frame_id",
type: { type: "primitive", name: "string" },
description:
"Frame of reference for the image. The origin of the frame is the optical center of the camera. +x points to the right in the image, +y points down, and +z points into the plane of the image.",
},
],
};

Expand Down Expand Up @@ -802,6 +814,12 @@ const RawImage: FoxgloveMessageSchema = {
type: { type: "primitive", name: "bytes" },
description: "Raw image data",
},
{
name: "frame_id",
type: { type: "primitive", name: "string" },
description:
"Frame of reference for the image. The origin of the frame is the optical center of the camera. +x points to the right in the image, +y points down, and +z points into the plane of the image.",
},
],
};

Expand Down