add frame_id to RawImage, CompressedImage, and CameraCalibration #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
changed the title
src/schemas.ts
Outdated
| name: "frame_id", | ||
| type: { type: "primitive", name: "string" }, | ||
| description: | ||
| "Frame of reference for the camera. The origin of the frame is the optical center of the camera. +x points to the right in the image, +y points down, and +z points into the plane of the image.", |
There was a problem hiding this comment.
Is it worth calling out that CameraCalibration should be in the same frame as its corresponding image? What happens if the CameraCalibration is a different frame?
There was a problem hiding this comment.
No idea really. Probably bad things.
defunctzombie
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Seems reasonable. Might be worth thinking through:
foxglove/studio#4323 (comment)
And whether there are other useful or common ways of tying cameras to calibration data and/or frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Added
frame_idto RawImage, CompressedImage, and CameraCalibrationDescription
Closes #59
Unblocks foxglove/studio#4323