Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

Some panels do not reset when player or seek time changes #1239

Closed
amacneil opened this issue Jun 15, 2021 · 0 comments · Fixed by #1241
Closed

Some panels do not reset when player or seek time changes #1239

amacneil opened this issue Jun 15, 2021 · 0 comments · Fixed by #1241
Assignees
@defunctzombie
Milestone
v0.12

Comments

@amacneil
Copy link
Contributor

Since #1008 was reverted by #1228, we are now back to not resetting state when player changes. This results in things like images from a previous connection still being displayed.
@amacneil amacneil added this to the v0.12 milestone Jun 15, 2021
@defunctzombie defunctzombie mentioned this issue Jun 15, 2021
Merged
@jtbandes jtbandes changed the title Players do not reset when player changes Some panels do not reset when player changes Jun 15, 2021
@jtbandes jtbandes changed the title Some panels do not reset when player changes Some panels do not reset when player or seek time changes Jun 15, 2021
defunctzombie added a commit that referenced this issue Jun 15, 2021
@defunctzombie
Remount panel layouts when player changes
7b76bc9 
Use RemountOnValueChange to unmount/remount panel layouts when players change.
This clears any local cache or state management the components may have related
to stale messages, state, etc.

Fixes #1239
defunctzombie added a commit that referenced this issue Jun 15, 2021
@defunctzombie
Remount panel layouts when player changes
f916134 
Use RemountOnValueChange to unmount/remount panel layouts when players change.
This clears any local cache or state management the components may have related
to stale messages, state, etc.

Fixes #1239
defunctzombie added a commit that referenced this issue Jun 16, 2021
@defunctzombie
Remount panel layouts when player changes
a8e85e9 
Use RemountOnValueChange to unmount/remount panel layouts when players change.
This clears any local cache or state management the components may have related
to stale messages, state, etc.

Fixes #1239
defunctzombie added a commit that referenced this issue Jun 16, 2021
@defunctzombie
Remount panel layouts when player changes (#1241)
3aa37e8 
Use RemountOnValueChange to unmount/remount panel layouts when players change.
This clears any local cache or state management the components may have related
to stale messages, state, etc.

Fixes #1239
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@defunctzombie defunctzombie

Labels
None yet
Milestone
v0.12
Development

Successfully merging a pull request may close this issue.

Reset all panels when player changes. foxglove/studio
2 participants
@defunctzombie @amacneil