This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Replace rc-color-picker with FluentUI's colorpicker #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
65c0605
to
df354c2
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
df354c2
to
35b40b5
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
35b40b5
to
eda528f
Compare
wkalt
commented
May 19, 2021
app/components/ColorPicker/index.tsx
Outdated
|
|
||
| export enum ButtonShape { | ||
| Circle, | ||
| } |
There was a problem hiding this comment.
separate file? just use a flag?
There was a problem hiding this comment.
or just buttonShape?: "circle" | "default"
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
3 times, most recently
from
6427307
to
7a5e77c
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
329c876
to
6fddcf3
Compare
|
@jtbandes @defunctzombie this is ready for a look |
jtbandes
reviewed
May 19, 2021
app/panels/Publish/index.tsx
Outdated
| @@ -35,7 +37,7 @@ type Config = { | |||
| datatype: string; | |||
| buttonText: string; | |||
| buttonTooltip: string; | |||
| buttonColor: string; | |||
| buttonColor: Color; | |||
There was a problem hiding this comment.
Changing this will not be backwards-compatible with existing saved layouts – we don't have any migration story right now but you might want to either keep this as a string, or do something like string | Color so you can at least guard against old values
|
there's an issue with this around coloring unlabeled markers with the topic tree. Taking a look at that. |
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
424f6fd
to
319a8fe
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
319a8fe
to
d7b7c43
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
d7b7c43
to
2ce8a13
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
2ce8a13
to
34c9d87
Compare
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
1f7cd33
to
546d50c
Compare
jtbandes
approved these changes
May 20, 2021
Replace rc-color-picker with FluentUI's ColorPicker, and split "ColorPickerForTopicSettings" into a standard new ColorPicker component for common usage.
wkalt
force-pushed
the
wyatt/GH-902/replace-rc-color-picker
branch
from
1d5aac0
to
0945837
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.