Clear topic subscription errors when new messages are received

[foxymiles]

User-Facing Changes
None

Description
Currently once we encounter a subscription error on a topic on a ROS connection we display a player error but we don't clear this error once the subscription to that topic is working again. The solution here is to clear the error once we successfully receive a message on that topic again.

Fixes #3293

[jhurliman]

Would the ROS2 player benefit from the same fix?

[foxymiles]

Would the ROS2 player benefit from the same fix?

Yeah looks like it. I'll add it there as well.

[defunctzombie]

Since there can be multiple publishers to a single topic - what happens when a subscriber to one of the publishers fails but the other is working? Would we still surface an error to the user? If we have a subscription id we should include that in the error key so we can clear only the errors for the subscription that is working again.

[foxymiles]

Good question. Looks like right now we don't know the id of the publisher that caused the error?

studio/packages/studio-base/src/players/Ros1Player.ts

Lines 401 to 408 in 5680d79

	subscription.on("error", (error) => {
	this._addProblem(`subscribe:${topicName}`, {
	severity: "warn",
	message: `Topic subscription error for "${topicName}"`,
	tip: `The subscription to "${topicName}" will be automatically re-established`,
	error,
	});
	});

[defunctzombie]

@foxymiles I see yes the subscription is for any publisher. We'd need to update our ros1 library to provide that additional information in the error. Something we'll have to stash away for later.