This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Restore former eslint settings #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
commented
Feb 25, 2021
| @@ -84,6 +84,7 @@ export type Store = { dispatch: Dispatch<unknown>; getState: () => State }; | |||
| // Fix the type definitions for connected-react-router | |||
| // The connectRouter function allows for omitting state and action | |||
| declare module "connected-react-router" { | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
There was a problem hiding this comment.
This one was hard — not sure if there is a right way to allow this kind of TS override. Maybe moving it into a .d.ts file. Anyway it didn't seem like a big deal.
amacneil
pushed a commit
that referenced
this pull request
Mar 8, 2021
Restores eslint settings from the webviz project, along with some modifications for TypeScript compatibility and newer eslint/webpack versions. Contains a workaround for import-js/eslint-plugin-import#1996.
amacneil
pushed a commit
that referenced
this pull request
Mar 8, 2021
Restores eslint settings from the webviz project, along with some modifications for TypeScript compatibility and newer eslint/webpack versions. Contains a workaround for import-js/eslint-plugin-import#1996.
amacneil
pushed a commit
that referenced
this pull request
Mar 8, 2021
Restores eslint settings from the webviz project, along with some modifications for TypeScript compatibility and newer eslint/webpack versions. Contains a workaround for import-js/eslint-plugin-import#1996.
amacneil
pushed a commit
that referenced
this pull request
Mar 8, 2021
Restores eslint settings from the webviz project, along with some modifications for TypeScript compatibility and newer eslint/webpack versions. Contains a workaround for import-js/eslint-plugin-import#1996.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores eslint settings from the webviz project, along with some modifications for TypeScript compatibility and newer eslint/webpack versions.