This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
[New3D] Patch THREE.js to improve custom shader performance #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Were you able to use the benchmark player to see the same improvements? |
jtbandes
reviewed
Aug 3, 2022
jtbandes
approved these changes
Aug 3, 2022
|
Have we searched for existing github issues on three.js about this performance concern? I think we should file one if there isn't one already, so that they are aware of the problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
3D (Beta)TEXT_VIEW_FACING rendering performanceDescription
For custom shaders, THREE.js uses the internal WebGLShaderCache class which contains a
Map<string, WebGLShaderStage>where the keys are vertex and fragment shader source code. This change patches THREE.js (viayarn patch) to useMaterial#vertexShaderKeyand/orMaterial#fragmentShaderKeyproperties as map keys when available. The cache lookup methods have also been rewritten to avoid unnecessary lookups.These new properties are used to speed up shader execution for TEXT_VIEW_FACING markers (
RenderableTextViewFacing). Performance tracing shows a ~30% reduction in frame times in the synthetic label benchmark on my machine after this change.