Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Upgrade react-mosaic-component and stop using the fork #410

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

jtbandes
Copy link
Member

react-mosaic was forked for reasons described at https://gist.github.com/troygibb/9be30ae863ea5da4ebdbf58f1eda8f49. We are now able to move off the fork with these adaptations:

  • Instead of reading mosaicId from the root mosaic component, just pick a uuid, and pass that in to all mosaics (thanks to Configurable mosaic ID nomcopter/react-mosaic#143).
  • Instead of MosaicDumbWindow and removeRootDropTarget, use a little bit of hacky CSS to add display: none to the unsavory drop targets.
  • Instead of threading tabId everywhere through the mosaic source code, add tabId using a feature of react-dnd where drop targets can read/overwrite drag context from nested drop targets.

@jtbandes jtbandes merged commit 9b49a60 into main Mar 31, 2021
@jtbandes jtbandes deleted the jacob/upgrade-react-mosaic branch March 31, 2021 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant