This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Upgrade react-mosaic-component and stop using the fork #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-mosaic was forked for reasons described at https://gist.github.com/troygibb/9be30ae863ea5da4ebdbf58f1eda8f49. We are now able to move off the fork with these adaptations:
mosaicId
from the root mosaic component, just pick a uuid, and pass that in to all mosaics (thanks to Configurable mosaic ID nomcopter/react-mosaic#143).MosaicDumbWindow
andremoveRootDropTarget
, use a little bit of hacky CSS to adddisplay: none
to the unsavory drop targets.tabId
everywhere through the mosaic source code, addtabId
using a feature of react-dnd where drop targets can read/overwrite drag context from nested drop targets.