This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Replace bobjects with LazyMessages #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Apr 21, 2021
app/components/MessagePathSyntax/useCachedGetMessagePathDataItems.ts
Outdated
Show resolved
Hide resolved
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
| @@ -589,8 +583,8 @@ export default class SceneBuilder implements MarkerProvider { | |||
| this.collectors[topic]!.addMarker(marker as any, name); | |||
| } | |||
|
|
|||
| _consumeMarker(topic: string, message: BinaryMarker | BinaryInstancedMarker): void { | |||
| const namespace = message.ns(); | |||
| _consumeMarker(topic: string, message: BaseMarker): void { | |||
There was a problem hiding this comment.
There is also an _addMarker function that is substantially identical. I think only one of these two functions should survive the 🔪
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
jtbandes
reviewed
Apr 21, 2021
| @@ -369,7 +366,7 @@ export default class RandomAccessPlayer implements Player { | |||
| this._end, | |||
| ); | |||
|
|
|||
| const { parsedMessages: messages, bobjects } = await this._getMessages(start, end); | |||
| const { parsedMessages: messages } = await this._getMessages(start, end); | |||
There was a problem hiding this comment.
should we be renaming this parsedMessages field to lazyMessages or just messages?
jtbandes
reviewed
Apr 21, 2021
| @@ -469,7 +461,7 @@ export default class RandomAccessPlayer implements Player { | |||
| ); | |||
| return undefined; | |||
| } | |||
| if (!topic.datatype) { | |||
| if (topic.datatype === "") { | |||
There was a problem hiding this comment.
I wonder if this is a bad type def - it seems unlikely that someone would have an empty string, more likely that it would be missing, but I'm guessing that the type defs don't allow it to be missing.
jtbandes
reviewed
Apr 21, 2021
defunctzombie
force-pushed
the
roman/hocho-bobjects
branch
5 times, most recently
from
760fdfb
to
433a07e
Compare
defunctzombie
force-pushed
the
roman/hocho-bobjects
branch
from
433a07e
to
3d50687
Compare
RewriteBinaryDataProvider is removed and logic in MemoryCacheDataProvider is updated to produce lazy messages into blocks.
defunctzombie
force-pushed
the
roman/hocho-bobjects
branch
from
3d50687
to
f78a535
Compare
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove separate "bobjects" code paths and provide lazy messages using the existing messages code paths.