This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Jump to settings button for selected object in 3d panel #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
approved these changes
Sep 26, 2023
Do you mean an interactive story? There are several stories that show the new button already. |
@foxymiles yeah I do. Looking for a story that clicks the button and opens the topic in the settings panel |
|
@jtbandes I added stories if you wouldn't mind checking their code to make sure they look fine. Had some strange issues where I had to send two point events and not sure if there's anything I can do about it |
jtbandes
approved these changes
Oct 13, 2023
snosenzo
deleted the
miles/fg-2423-jump-to-topic-settings-for-selected-object-in-3d
branch
pezy
pushed a commit
to pezy/studio
that referenced
this pull request
Oct 25, 2023
**User-Facing Changes** Add button to jump to per-topic settings in the 3d panel object inspector. **Description** Put this alongside the existing link to open a raw messages panel: <img width="318" alt="Screenshot 2023-09-25 at 9 43 50 AM" src="https://github.com/foxglove/studio/assets/93935560/d2a11c65-d23b-4600-9ed4-e7c0f9db0386"> <!-- link relevant GitHub issues --> <!-- add `docs` label if this PR requires documentation updates --> <!-- add relevant metric tracking for experimental / new features --> --------- Co-authored-by: Sam Nosenzo <samnosenzo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Add button to jump to per-topic settings in the 3d panel object inspector.
Description
Put this alongside the existing link to open a raw messages panel: