Add size setting for plot lines #7013
Conversation
|
Internal tracking issue: FG-5377 |
|
Looks good to me! Might wanna try rebasing and pushing again to see if that test error will disappear |
| @@ -58,6 +58,14 @@ const makeSeriesNode = memoizeWeak( | |||
| label: t("color"), | |||
| value: path.color ?? lineColors[index % lineColors.length], | |||
| }, | |||
| size: { | |||
There was a problem hiding this comment.
Maybe we can rename this (and the settings key) to lineSize? Seems better to be a bit more explicit for future sanity.
| @@ -58,6 +58,14 @@ const makeSeriesNode = memoizeWeak( | |||
| label: t("color"), | |||
| value: path.color ?? lineColors[index % lineColors.length], | |||
| }, | |||
| size: { | |||
| input: "number", | |||
| label: "Line Size", | |||
There was a problem hiding this comment.
This should be t("lineSize") and added to i18n/en/plot.ts so it can be localized. Also we generally use sentence case, i.e. "Line size" instead of "Line Size".
alexern14
force-pushed
the
feature/add-plot-line-size-setting
branch
from
cd599b2
to
bd6f01a
Compare
|
@jtbandes This is my first time putting up a PR for you guys. What's the process for getting the UI reviewed, tests approved, and Vercel authorized? |
|
We can take care of the approval/merging step. Could you also add another entry to |
alexern14
force-pushed
the
feature/add-plot-line-size-setting
branch
4 times, most recently
from
25d2f99
to
5a19037
Compare
| showLine: false, | ||
| timestampMethod: "receiveTime", | ||
| lineSize: 1.4, |
There was a problem hiding this comment.
Making the difference more obvious since it currently doesn't really show up in the screenshot: https://www.chromatic.com/test?appId=603ec8bf7908b500231841e2&id=6542cd42f98cef426c29a020
| showLine: false, | |
| timestampMethod: "receiveTime", | |
| lineSize: 1.4, | |
| timestampMethod: "receiveTime", | |
| lineSize: 2.5, |
alexern14
force-pushed
the
feature/add-plot-line-size-setting
branch
from
5a19037
to
91628e3
Compare
| { | ||
| value: "/some_topic/location.pose.velocity", | ||
| enabled: true, | ||
| showLine: false, |
There was a problem hiding this comment.
Please remove the showLine: false too since otherwise we see only the points in the screenshot. The new 2.5 size looks good though! They're obviously bigger than the other points
alexern14
force-pushed
the
feature/add-plot-line-size-setting
branch
from
91628e3
to
92726cf
Compare
|
Thank you! |
**User-Facing Changes** Add line size setting option to plot panel.
User-Facing Changes
Add line size setting option to plot panel.
Description
The following image shows the blue series with the auto line size which is unchanged, and the orange series with an increased line size.
