Add tooltip to 3d floating buttons

[2metres]

User-Facing Changes
None

Description
Use MUI tooltip instead of native title element

Screen.Recording.2023-12-20.at.8.48.56.pm.mov

[defunctzombie]

The reason we hadn't done this before is because the mui tooltip has very poor performance for re-rendering when we last profiled it and I am hesitant to add another use of it in a location that renders at 60fps. Have we fixed these performance concerns?

[defunctzombie]

See comment about performance concerns. Convince me this is ok to add to a panel rendering at 60fps.

[2metres]

Do we have something documenting the how to test the performance benchmarks that we need to pass for this?

[2metres]

Throwing a tooltip around a button in the ui-benchmarking tool certainly doesn't bode well.

[jtbandes]

One would hope that the RendererOverlay is not re-rendering at 60fps, during panning or playback. I am not saying I know for sure it doesn't – just that I would hope it doesn't 😅

[2metres]

One would hope that the RendererOverlay is not re-rendering at 60fps, during panning or playback. I am not saying I know for sure it doesn't – just that I would hope it doesn't 😅

From memory this should be true. But I also have no way of testing this

[2metres]

From what I can tell the RendererOverlay does not re-render at 60fps. I think this PR is safe to merge.

Investigated the render overlay and the learning is that we do not think it renders at 60 fps

[defunctzombie]

👍

Unrelated to the PR but it would be nice to find ways of using smaller component files for some of these things. It would make it more obvious which components use what state and selectors and what will cause them to re-render. I think we should be doing that across the codebase more.