This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Abort blockloader when player is closing #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
requested review from
defunctzombie,
jtbandes and
achim-k
and removed request for
defunctzombie
defunctzombie
approved these changes
Jan 17, 2024
achim-k
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Description
#abortController.abort()was not being called inBlockloader.stopLoadingso the blockloader would need to finish loading before the player was closed.We also might want to consider adding a timeout for a warning or error when
stateCloseis called on the player so that we know if the last player didn't close in a reasonable amount of time.