This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix collada textures not being loaded #7407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
approved these changes
Jan 29, 2024
No I don't think that there is an issue, especially since models are cached, so temporary object URLs are created only once for every model URL |
jtbandes
reviewed
Jan 30, 2024
| @@ -220,25 +219,21 @@ export class ModelCache { | |||
| const objectUrl = URL.createObjectURL( | |||
| new Blob([textureAsset.data], { type: textureAsset.mediaType }), | |||
| ); | |||
| textureUrls.set(textureUrl, objectUrl); | |||
| this.#colladaTextureObjectUrls.set(textureUrl, objectUrl); | |||
There was a problem hiding this comment.
Should we check if one already exists before creating a new one here?
There was a problem hiding this comment.
Good remark, I'll create a follow-up PR for this
amacneil
pushed a commit
that referenced
this pull request
Jan 31, 2024
**User-Facing Changes** None **Description** Follow up of #7407 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Fix collada textures not being loaded
Description
We were revoking temporary object URLs to early, resulting in errors when loading these URLs. This PR ties the lifetime of these temporary object URLs to the lifetime of the ModelCache.