Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

Workaround for webpack --watch / fork-ts-checker issues #967

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 19 additions & 2 deletions desktop/main/tsconfig.json
@@ -1,8 +1,25 @@
{
"extends": "@foxglove/tsconfig/tsconfig.base.json",
"include": ["./**/*", "../common/*", "../../package.json"],
"include": [
"./**/*",
"../common/*",
"../../package.json",
// These includes are added to ensure that fork-ts-checker correctly typechecks changed files:
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"../../app/AppSetting.ts",
"../../packages/log/src/**/*"
],
"compilerOptions": {
"rootDir": "../../",
"noEmit": true
"noEmit": true,

// These paths are added to ensure that fork-ts-checker correctly typechecks changed files.
// Using these resolutions will force TS to give us an error if we forgot to add these files to
// one of our tsconfig "include"s.
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"paths": {
"@foxglove/studio-base/*": ["../../app/*"],
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"]
}
}
}
25 changes: 23 additions & 2 deletions desktop/preload/tsconfig.json
@@ -1,9 +1,30 @@
{
"extends": "@foxglove/tsconfig/tsconfig.base.json",
"include": ["./**/*", "../common/*", "../../package.json"],
"include": [
"./**/*",
"../common/*",
"../../package.json",

// These includes are added to ensure that fork-ts-checker correctly typechecks changed files:
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"../../app/AppSetting.ts",
"../../app/OsContext.ts",
"../../packages/electron-socket/*",
"../../packages/electron-socket/src/**/*",
"../../packages/log/src/**/*"
],
"compilerOptions": {
"rootDir": "../../",
"noEmit": true,
"lib": ["dom", "es2020"]
"lib": ["dom", "es2020"],

// These paths are added to ensure that fork-ts-checker correctly typechecks changed files.
// Using these resolutions will force TS to give us an error if we forgot to add these files to
// one of our tsconfig "include"s.
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"paths": {
"@foxglove/studio-base/*": ["../../app/*"],
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"]
}
}
}
27 changes: 25 additions & 2 deletions desktop/renderer/tsconfig.json
@@ -1,10 +1,33 @@
{
"extends": "@foxglove/tsconfig/tsconfig.base.json",
"include": ["./**/*", "../common/**/*", "../../package.json"],
"include": [
"./**/*",
"../common/**/*",
"../../package.json",

// These includes are added to ensure that fork-ts-checker correctly typechecks changed files:
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"../../app/**/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait on this until we move app into packages

"../../app/**/*.json",
"../../app/.storybook/**/*",
"../../packages/@foxglove/*/src/**/*",
"../../packages/*/src/**/*",
"../../packages/electron-socket/*",
"../../packages/velodyne-cloud/src/**/*.json"
],
"compilerOptions": {
"rootDir": "../../",
"noEmit": true,
"jsx": "react-jsx",
"lib": ["dom", "dom.iterable", "es2020"]
"lib": ["dom", "dom.iterable", "es2020"],

// These paths are added to ensure that fork-ts-checker correctly typechecks changed files.
// Using these resolutions will force TS to give us an error if we forgot to add these files to
// one of our tsconfig "include"s.
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611
"paths": {
"@foxglove/studio-base/*": ["../../app/*"],
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"]
}
}
}