This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 423
Workaround for webpack --watch
/ fork-ts-checker issues
#967
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3c442db
Force fork-ts-checker to watch all TS files in the repo
jtbandes a96750c
Merge remote-tracking branch 'origin/main' into jacob/tsconfig-paths-…
jtbandes 50d3872
cleanup
jtbandes d0ece13
foxglove-studio/app -> foxglove/studio-base
jtbandes 54dbc43
fixes
jtbandes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,25 @@ | ||
{ | ||
"extends": "@foxglove/tsconfig/tsconfig.base.json", | ||
"include": ["./**/*", "../common/*", "../../package.json"], | ||
"include": [ | ||
"./**/*", | ||
"../common/*", | ||
"../../package.json", | ||
// These includes are added to ensure that fork-ts-checker correctly typechecks changed files: | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"../../app/AppSetting.ts", | ||
"../../packages/log/src/**/*" | ||
], | ||
"compilerOptions": { | ||
"rootDir": "../../", | ||
"noEmit": true | ||
"noEmit": true, | ||
|
||
// These paths are added to ensure that fork-ts-checker correctly typechecks changed files. | ||
// Using these resolutions will force TS to give us an error if we forgot to add these files to | ||
// one of our tsconfig "include"s. | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"paths": { | ||
"@foxglove/studio-base/*": ["../../app/*"], | ||
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,30 @@ | ||
{ | ||
"extends": "@foxglove/tsconfig/tsconfig.base.json", | ||
"include": ["./**/*", "../common/*", "../../package.json"], | ||
"include": [ | ||
"./**/*", | ||
"../common/*", | ||
"../../package.json", | ||
|
||
// These includes are added to ensure that fork-ts-checker correctly typechecks changed files: | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"../../app/AppSetting.ts", | ||
"../../app/OsContext.ts", | ||
"../../packages/electron-socket/*", | ||
"../../packages/electron-socket/src/**/*", | ||
"../../packages/log/src/**/*" | ||
], | ||
"compilerOptions": { | ||
"rootDir": "../../", | ||
"noEmit": true, | ||
"lib": ["dom", "es2020"] | ||
"lib": ["dom", "es2020"], | ||
|
||
// These paths are added to ensure that fork-ts-checker correctly typechecks changed files. | ||
// Using these resolutions will force TS to give us an error if we forgot to add these files to | ||
// one of our tsconfig "include"s. | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"paths": { | ||
"@foxglove/studio-base/*": ["../../app/*"], | ||
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,33 @@ | ||
{ | ||
"extends": "@foxglove/tsconfig/tsconfig.base.json", | ||
"include": ["./**/*", "../common/**/*", "../../package.json"], | ||
"include": [ | ||
"./**/*", | ||
"../common/**/*", | ||
"../../package.json", | ||
|
||
// These includes are added to ensure that fork-ts-checker correctly typechecks changed files: | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"../../app/**/*", | ||
"../../app/**/*.json", | ||
"../../app/.storybook/**/*", | ||
"../../packages/@foxglove/*/src/**/*", | ||
"../../packages/*/src/**/*", | ||
"../../packages/electron-socket/*", | ||
"../../packages/velodyne-cloud/src/**/*.json" | ||
], | ||
"compilerOptions": { | ||
"rootDir": "../../", | ||
"noEmit": true, | ||
"jsx": "react-jsx", | ||
"lib": ["dom", "dom.iterable", "es2020"] | ||
"lib": ["dom", "dom.iterable", "es2020"], | ||
|
||
// These paths are added to ensure that fork-ts-checker correctly typechecks changed files. | ||
// Using these resolutions will force TS to give us an error if we forgot to add these files to | ||
// one of our tsconfig "include"s. | ||
// https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
"paths": { | ||
"@foxglove/studio-base/*": ["../../app/*"], | ||
"@foxglove/*": ["../../packages/*", "../../packages/foxglove/*"] | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wait on this until we move app into packages