Add support for proxying to a Unix socket #40
Conversation
| @@ -75,7 +77,12 @@ import UnliftIO (MonadIO, liftIO, MonadUnliftIO, | |||
| data ProxyDest = ProxyDest | |||
| { pdHost :: !ByteString | |||
| , pdPort :: !Int | |||
| } deriving (Read, Show, Eq, Ord, Generic) | |||
| } | |||
| | ProxyDestUnix { | |||
There was a problem hiding this comment.
I'm not a fan of this approach, since it creates partial functions as well as breaking existing code that pattern matches. A new data type would be necessary.
There was a problem hiding this comment.
Okay, could you clarify what you have in mind? Avoiding a breaking change would seem to require a lot of duplication. For example, where we have
rawTcpProxyTo :: MonadIO m => ProxyDest -> AppData -> m ()I could create a parallel universe of functions like
rawTcpProxyToUnix :: MonadIO m => ProxyDestUnix -> AppData -> m ()but that would require duplicating most of public proxying functions as well as WaiProxyResponse...
There was a problem hiding this comment.
Unfortunately I don't have a specific recommendation in mind.
There was a problem hiding this comment.
Would you accept a full breaking change, renaming the data type and bumping the version number?
There was a problem hiding this comment.
I would lean towards creating a parallel set of functions.
The crux of this PR is adding a new constructor to the
ProxyDesttype calledProxyDestUnix, and hooking it up to a call toData.Conduit.Network.Unix.runUnixClient.Happy to add a test or two if you think this could be mergeable. Thanks!