Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up req_t/ack_t #65

Open
quetric opened this issue Jun 19, 2024 · 0 comments
Open

Clean up req_t/ack_t #65

quetric opened this issue Jun 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@quetric
Copy link

quetric commented Jun 19, 2024

The request/completion structures contain several stale fields which should be cleaned up. Also mode should be merged into opcode as it doesn't currently provide any additional information.

Specifically, the following fields seem like can be removed:

  • remote
  • host
  • rdma
  • mode (can be replaced by inspecting verb)
@bo3z bo3z added the enhancement New feature or request label Oct 22, 2024
@bo3z bo3z added the good first issue Good for newcomers label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quetric @bo3z