Skip to content

Commit

Permalink
Remove unused function 👻
Browse files Browse the repository at this point in the history
The function `GetLogMessages` isn't used anywhere. I had tried to remove
it to see if it was causing the data race in tektoncd#1124 - it _isnt_ but still
it's not being used anywhere so why not remove :)
  • Loading branch information
bobcatfish authored and tekton-robot committed Sep 15, 2019
1 parent 5e3276d commit 17c45ee
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions test/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,12 @@ import (
"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1"
fakepipelineclientset "github.com/tektoncd/pipeline/pkg/client/clientset/versioned/fake"
informersv1alpha1 "github.com/tektoncd/pipeline/pkg/client/informers/externalversions/pipeline/v1alpha1"
"go.uber.org/zap/zaptest/observer"
corev1 "k8s.io/api/core/v1"
coreinformers "k8s.io/client-go/informers/core/v1"
fakekubeclientset "k8s.io/client-go/kubernetes/fake"
"knative.dev/pkg/controller"
)

// GetLogMessages returns a list of all string logs in logs.
func GetLogMessages(logs *observer.ObservedLogs) []string {
messages := []string{}
for _, l := range logs.All() {
messages = append(messages, l.Message)
}
return messages
}

// Data represents the desired state of the system (i.e. existing resources) to seed controllers
// with.
type Data struct {
Expand Down Expand Up @@ -86,7 +76,6 @@ type Informers struct {
// TestAssets holds references to the controller, logs, clients, and informers.
type TestAssets struct {
Controller *controller.Impl
Logs *observer.ObservedLogs
Clients Clients
}

Expand Down

0 comments on commit 17c45ee

Please sign in to comment.