Skip to content

Commit

Permalink
Use Tekton's nightly-built build-base image
Browse files Browse the repository at this point in the history
Apparently the knative-nightly build-base image hasn't been built since
February?!
  • Loading branch information
imjasonh authored and tekton-robot committed Sep 26, 2019
1 parent bcbba97 commit 40e340f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions .ko.yaml
@@ -1,7 +1,6 @@
baseImageOverrides:
# TODO(christiewilson): Use our built base image
github.com/tektoncd/pipeline/cmd/creds-init: gcr.io/knative-nightly/github.com/knative/build/build-base:latest
github.com/tektoncd/pipeline/cmd/git-init: gcr.io/knative-nightly/github.com/knative/build/build-base:latest
github.com/tektoncd/pipeline/cmd/creds-init: gcr.io/tekton-nightly/github.com/tektoncd/pipeline/build-base:latest
github.com/tektoncd/pipeline/cmd/git-init: gcr.io/tekton-nightly/github.com/tektoncd/pipeline/build-base:latest
github.com/tektoncd/pipeline/cmd/bash: busybox # image should have shell in $PATH
github.com/tektoncd/pipeline/cmd/entrypoint: busybox # image should have shell in $PATH
github.com/tektoncd/pipeline/cmd/gsutil: google/cloud-sdk:alpine # image should have gsutil in $PATH
2 changes: 1 addition & 1 deletion test/git_checkout_test.go
Expand Up @@ -126,7 +126,7 @@ func TestGitPipelineRunFail(t *testing.T) {
t.Fatalf("Error getting pod logs for pod `%s` and container `%s` in namespace `%s`", tr.Status.PodName, stat.Name, namespace)
}
// Check for failure messages from fetch and pull in the log file
if strings.Contains(string(logContent), "Couldn't find remote ref Idontexistrabbitmonkeydonkey") &&
if strings.Contains(string(logContent), "couldn't find remote ref Idontexistrabbitmonkeydonkey") &&
strings.Contains(string(logContent), "pathspec 'Idontexistrabbitmonkeydonkey' did not match any file(s) known to git") {
t.Logf("Found exepected errors when retrieving non-existent git revision")
} else {
Expand Down

0 comments on commit 40e340f

Please sign in to comment.