Reducing canvas memory usage #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab68333:
|
adamseckel
reviewed
Mar 10, 2021
| @@ -98,6 +98,7 @@ export function resolveVariant( | |||
| export function checkIfControllingVariants(props: MotionProps) { | |||
| return ( | |||
| typeof (props.animate as AnimationControls)?.start === "function" || | |||
| isVariantLabel(props.initial) || | |||
There was a problem hiding this comment.
Is this a drive by fix?
adamseckel
reviewed
Mar 10, 2021
dev/tests/svg.tsx
Outdated
| @@ -21,7 +21,7 @@ export const App = () => { | |||
| data-testid="rotate" | |||
| style={{ rotate: 45 }} | |||
| /> | |||
| <motion.rect | |||
| {/* <motion.rect | |||
There was a problem hiding this comment.
This need to stay commented out?
adamseckel
approved these changes
Mar 10, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for a
motioncomponent to render in static mode without instantiating aVisualElement, significantly reducing memory consumption.A
VisualElementis an abstraction around the renderer, by default the DOM. It enables us to performantly interact with the renderer and to communicate throughout the tree, away from React and its lifecycles. We create one for everymotioncomponent.Static mode is a flag we can switch on in the Framer canvas and in server rendering where
motioncomponents behave more like normal elements in that a newstyletag is created every render and no animations/gestures are mounted.This PR changes the architecture slightly so that the initial map of values is created externally from the
VisualElementand can itself either be used to render themotioncomponent via React in static mode or to instantiate theVisualElementin normal mode.This will save hundreds of megabytes of memory consumption from the Framer canvas in large prototypes. In a future refactor I'll change the
VisualElementfactory function to aclasswhich will cut memory consumption in normal mode also.This architecture also gets us pretty close to allowing the
VisualElementitself to be lazy loaded, so we can bring themcomponent down from 13kb to something closer to 5.