Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor special device handling #763

Closed
framps opened this issue Jun 3, 2024 · 1 comment
Closed

Refactor special device handling #763

framps opened this issue Jun 3, 2024 · 1 comment
Assignees
@framps
Labels
development Development issues

Comments

@framps
Copy link
Owner

framps commented Jun 3, 2024

As of now there are various checks for mmcblk, loop and nvme because the partition naming has p appended in contrast to sdx. Use one common function to check.

A more general criteria to append a p is whether the block device ends with a number.
@framps framps added the development Development issues label Jun 3, 2024
@framps framps self-assigned this Jun 3, 2024
framps added a commit that referenced this issue Jun 3, 2024
@framps
Implementation of #763
629990e
framps added a commit that referenced this issue Jun 3, 2024
@framps
Implementation of #763
6d8a1da
framps added a commit that referenced this issue Jun 3, 2024
@framps
Added unit tests for #763
f620d75
@framps
Copy link
Owner Author

framps commented Jun 17, 2024

Code merged into #748

@framps framps closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@framps framps

Labels
development Development issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@framps