Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with GNOME Terminal in Wayland session #24

Closed
anupam207 opened this issue Sep 18, 2017 · 7 comments
Closed

Doesn't work with GNOME Terminal in Wayland session #24

anupam207 opened this issue Sep 18, 2017 · 7 comments

Comments

@anupam207
Copy link

anupam207 commented Sep 18, 2017

Title bar doesn't go away if I maximize GNOME Terminal in Wayland session. I noticed this for Terminal, but I think it happens with all the windows running in Wayland. Windows running in XWayland, for example Firefox, seem to behave as expected.

Distro: Ubuntu GNOME 17.04, shell version 3.24.2

@franglais125
Copy link
Owner

Hi, thanks for taking the time of opening an issue!

In this case, unfortunately there is nothing I can do. This extension only works on X and on XWayland windows. Since GNOME terminal runs natively on Wayland, I can't remove the title bar.

Note that this is not a problem with the extension, or something I can fix, it simply can't be done with an extension.

For more info you can look at this issue #19.

Sorry! And cheers!

@anupam207
Copy link
Author

No problem. Thanks for your quick reply. Strange to see Terminal not using client side decoration like other GNOME apps. Hope they'll fix it soon.

@franglais125
Copy link
Owner

Indeed, I'd like that too!

Closing...

@franglais125
Copy link
Owner

I got this working on Wayland with the latest version from git. Would you mind testing it?

@anupam207
Copy link
Author

@franglais125 I've moved back to Xorg as so many things were not working with Wayland :( I'll test the new version as soon as I start trying Wayland again. But can't promise it'll be very soon :(

@morphheus
Copy link

morphheus commented Nov 24, 2017

As of today, on a fresh gnome 3.26 install, gnome-terminal's borders do not get removed on Wayland.
edit: I wasn't using the the git version :S. I can confirm that this extension works for gnome-terminal in Wayland. However, it requried a relogin for it to take effect.

@franglais125
Copy link
Owner

@morphheus great to know that it works for you :). And yes, a relogin is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants