Removed panda_moveit_config dependency in franka_ros #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, it probably makes sense to remove the dependency, but that will not fix the build issues because Probably we could remove Thanks! |
|
Done, just removed the dependency in package.xml |
|
Thanks! |
gollth
added a commit
that referenced
this pull request
Aug 3, 2021
…azebo * commit '4adb450f218c576631bf5e52cc51941d57769de0': ADD: Implementation for Body Jacobian in `ModelKDL`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have been installing franka_ros with ros noetic on ubuntu 20.04 and I noticed that the ros-noetic-franka-ros is not available on apt. By taking a quick look at jenkins (https://build.ros.org/job/Ndev__franka_ros__ubuntu_focal_amd64/4/console) it looks like the build is failing due to the panda_moveit_config dependency in franka_ros. This because panda_moveit_config is also not available in noetic. From what I understand this dependency is a remnant from when panda_moveit_config was a part of this repository, so it should be possible to safely remove it.