Try to determine if a datasource already does pooling #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.
jkosternl
approved these changes
Feb 1, 2024
| private static boolean isPooledDataSource(CommonDataSource dataSource) { | ||
| return dataSource instanceof ConnectionPoolDataSource | ||
| || dataSource.getClass().getName().startsWith("org.apache.tomcat") | ||
| ; |
There was a problem hiding this comment.
At least we fix the Tomcat issues with this solution, which is the most important application server used by F!F in the wild.
Cosmetic minor remark: this can also be put at one line?
Also something like this can be added:
// Datasource from Tomcat is already doing pooling or perhaps that's already obvious.
Or a Javadoc before the method: True if Tomcat connection pooling is used
nielsm5
approved these changes
Feb 1, 2024
nielsm5
approved these changes
Feb 1, 2024
nielsm5
deleted the
issue/7.9/6117_AvoidCreatingPoolAroundPoolingDataSource
branch
tnleeuw
added a commit
that referenced
this pull request
Feb 1, 2024
Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.
nielsm5
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Add Connection Pool Validation (#6119) (Cherrypick from 8a26d34) * PoolingJndiDataSourceFactory shouldn't check for DataSource to be XA or not XA (#6187) * Try to determine if a datasource already does pooling (#6199) Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.
tnleeuw
added a commit
that referenced
this pull request
Feb 5, 2024
* Add Connection Pool Validation (#6119) (Cherrypick from 8a26d34) * PoolingJndiDataSourceFactory shouldn't check for DataSource to be XA or not XA (#6187) * Try to determine if a datasource already does pooling (#6199) Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured. (cherry picked from commit 281bf1e)
nielsm5
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Add Connection Pool Validation (#6119) (Cherrypick from 8a26d34) * PoolingJndiDataSourceFactory shouldn't check for DataSource to be XA or not XA (#6187) * Try to determine if a datasource already does pooling (#6199) Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured. (cherry picked from commit 281bf1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.
I'm not sure about these changes, want to see if all works well in the Jenkins matrix builds. Am open to suggestions for better way to check.