Add Connection Validation and Pool configuration #6212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Cherrypick from 8a26d34)
Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.
jkosternl
requested changes
Feb 2, 2024
| maxLifeTimeSeconds = appConstants.getInt("transactionmanager.narayana.jdbc.connection.maxLifeTime", maxLifeTimeSeconds); | ||
| maxIdle = appConstants.getInt("transactionmanager.narayana.jdbc.connection.maxIdle", maxIdle); | ||
| maxLifeTime = appConstants.getInt("transactionmanager.narayana.jdbc.connection.maxLifeTime", maxLifeTime); | ||
| testQuery = appConstants.getString("transactionmanager.narayana.jdbc.connection.testQuery", testQuery); |
There was a problem hiding this comment.
All these extra/new features we set are valuable improvements, to my humble opinion, even though perhaps Ali's main issue was solved differently.
test/src/main/configurations/JMS/ConfigurationEsbJmsListenerSender.xml
Outdated
Show resolved
Hide resolved
jkosternl
approved these changes
Feb 3, 2024
|
nielsm5
approved these changes
Feb 5, 2024
tnleeuw
added a commit
that referenced
this pull request
Feb 5, 2024
* Add Connection Pool Validation (#6119) (Cherrypick from 8a26d34) * PoolingJndiDataSourceFactory shouldn't check for DataSource to be XA or not XA (#6187) * Try to determine if a datasource already does pooling (#6199) Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured. (cherry picked from commit 281bf1e)
nielsm5
reviewed
Feb 6, 2024
| @@ -30,6 +30,7 @@ | |||
| </property> | |||
| </bean> | |||
|
|
|||
| <bean id="dataSourceFactory" class="nl.nn.adapterframework.jndi.PoolingJndiDataSourceFactory" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.